ostree-remount: Check for / being *mounted* read-only, not necessarily writable

The previous S_IMMUTABLE commit broke ostree-remount; / is now not
actually writable.  All we really wanted to know though was whether it
was *mounted* writable, so check that via statvfs() which is cleaner
anyways (i.e. not via access() which kernel people hate).

https://bugzilla.gnome.org/show_bug.cgi?id=728006

diff --git a/src/switchroot/ostree-remount.c b/src/switchroot/ostree-remount.c
index 6dbeecc0e0489685152a6876aff5c77f22d9a3d7..84d9359c13c19ccf0a2a6cc0e1af11452e8bf4f4 100644 (file)
--- a/src/switchroot/ostree-remount.c
+++ b/src/switchroot/ostree-remount.c
@@ -28,6 +28,7 @@
 #include <stdint.h>
 #include <sys/param.h>
 #include <sys/mount.h>
+#include <sys/statvfs.h>
 #include <fcntl.h>
 #include <stdlib.h>
 #include <unistd.h>
@@ -42,8 +43,15 @@ main(int argc, char *argv[])
   const char *remounts[] = { "/sysroot", "/etc", "/home", "/root", "/tmp", "/var", NULL };
   struct stat stbuf;
   int i;
+  struct statvfs stvfsbuf;
 
-  if (access ("/", W_OK) == -1)
+  if (statvfs ("/", &stvfsbuf) == -1)
+    {
+      perror ("statvfs(/): ");
+      exit (1);
+    }
+
+  if (stvfsbuf.f_flag & ST_RDONLY)
     {
       /* If / isn't writable, don't do any remounts; we don't want
        * to clear the readonly flag in that case.